RFR: 8247732: validate user-input intrinsic_ids in ControlIntrinsic [v9]

Tue Dec 8 09:29:13 UTC 2020

On Thu, 3 Dec 2020 21:54:12 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8247732: validate user-input intrinsic_ids in ControlIntrinsic
>>   
>>   fix build failures on windows platform by using platform-natural MIN2.
>
> Looks good!

@neliasso @TobiHartmann 

I've updated tests to use the new form -- CompileCommand=ControlIntrinsic,*.*,+_id etc. it can dodge the problem JDK-8257800. I also fixed some corner cases that made random tests flaky. 

Could you take a look and verify it?  if everything looks good, could you sponsor this PR. thank you. 

btw, https://github.com/openjdk/jdk/pull/1652 is now completely independent from this PR. I will append a unittest to it soon.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1179