RFR: 8247732: validate user-input intrinsic_ids in ControlIntrinsic [v11]

[Xin Liu]

On Wed, 9 Dec 2020 06:41:38 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   change to the new CompileCommand format ControlIntrinsic,<method patter>,arguments
>
> src/hotspot/share/compiler/compilerDirectives.hpp line 194:
> 
>> 192: 
>> 193:  public:
>> 194:   ControlIntrinsicValidator(ccstrlist option, bool disabled_all) : _valid(true), _bad(nullptr) {
> 
> The argument of `ControlIntrinsicIter` is called `disable_all`, so it should be `disable_all` here as well.
> 
> The comment in `ControlIntrinsicIter` is confusing:
> // if disable_all is true, it accepts DisableIntrinsic(deprecated) and all intrinsics
> // appear in the list are to disable
> 
> Could you explain what exactly `disabled_all` is needed for?

before ControlIntrinsic, we have only this option: 
-XX:DisableIntrinsic=_id1,_id2,_id3,...

With ControlIntrinsic, we can have this form, + means enable, - means disable. 
-XX:ControlIntrinsic=+_id1, -_id2,+_id3,...

After DisableIntrinsic, we can still use this form. in this case, ControlIntrinsic is just an alias of  DisableIntrinsic. 
-XX:ControlIntrinsic=_id1, _id2,_id3,...

-------------

PR: https://git.openjdk.java.net/jdk/pull/1179