RFR: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume [v7]

Xin Liu xliu at openjdk.java.net
Thu Dec 10 00:28:56 UTC 2020


> if users don't specify method_name in CompileCommand, hotspot will over consume a token.
> in debug build, it may hit the assertion of type mismatch.

Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Merge branch 'master' into JDK-8257800
 - fix a corner case. won't treat it as an error if it's dead of string.
 - add the case -XX:CompileCommand=dontinline,*::dontinline_*" to the unittest
 - Merge branch 'master' into JDK-8257800
 - fix regression failure test/jdk/com/sun/jdi/EATests.java
 - add a unittest to test over-consume situation
 - fix building failure on Windows and chage parse_option_type to a public static member function.
 - 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1652/files
  - new: https://git.openjdk.java.net/jdk/pull/1652/files/13e5be3f..d9e1a138

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1652&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1652&range=05-06

  Stats: 5469 lines in 268 files changed: 3366 ins; 1224 del; 879 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1652.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1652/head:pull/1652

PR: https://git.openjdk.java.net/jdk/pull/1652


More information about the hotspot-compiler-dev mailing list