RFR: 8258015: [JVMCI] JVMCI_lock shouldn't be held while initializing box classes

Jie Fu jiefu at openjdk.java.net
Thu Dec 10 06:33:45 UTC 2020


Hi all,

Plenty of AOT tests failed after JDK-8257917.
The reason is that JVMCI_lock [1] was held during box classes initilization.
However, this assert [2] doesn't allow a lock (except tty_lock [3]) to be held in that case.
So JVMCI_lock here [1] should be removed.

Testing:
  compiler/aot and compiler/jvmci on Linux/x64

Thanks.
Best regards,
Jie


[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/jvmci/jvmci.cpp#L133
[2] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/thread.cpp#L795
[3] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/mutex.cpp#L440

-------------

Commit messages:
 - 8258015: [JVMCI] JVMCI_lock shouldn't be held while initializing box classes

Changes: https://git.openjdk.java.net/jdk/pull/1727/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1727&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8258015
  Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1727.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1727/head:pull/1727

PR: https://git.openjdk.java.net/jdk/pull/1727


More information about the hotspot-compiler-dev mailing list