[jdk16] RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads

[Richard Reingruber]

On Fri, 11 Dec 2020 20:53:37 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> This is a clone of https://github.com/openjdk/jdk/pull/1625 which was reviewed but not integrated before RDP1
>> 
>> The change is a test bug fix which can be integrated during RDP1 according to https://openjdk.java.net/jeps/3
>> 
>> --- Original Synopsis
>> 
>> This fixes a bug in the test test/jdk/com/sun/jdi/EATests.java that caused
>> timeout failures when graal is enabled.
>> 
>> The fix is to avoid suspending all threads when a breakpoint is reached and then resume
>> just the main thread again. This pattern was used in the test case
>> EAMaterializeLocalAtObjectPollReturnReturn. It caused timeouts because graal
>> threads remained suspended and, running with -Xbatch, the main thread waited
>> (with timeout) for completion of compile tasks.
>> The fix was applied to all breakpoints in the test. All explicit suspend calls now apply only
>> to the main test thread and all explicit resume calls apply to all java threads.
>> 
>> Testing: duration of the test case EAMaterializeLocalAtObjectPollReturnReturn is
>> reduced from 30s to 10s.
>
> Marked as reviewed by cjplummer (Reviewer).

Thanks for the reviews @plummercj, @sspitsyn, @TheRealMDoerr!

-------------

PR: https://git.openjdk.java.net/jdk16/pull/7