RFR: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume [v9]

[Tobias Hartmann]

On Tue, 15 Dec 2020 19:53:18 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> if users don't specify method_name in CompileCommand, hotspot will over consume a token.
>> in debug build, it may hit the assertion of type mismatch.
>
> Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - return early so it doesnot need to set m_match
>  - Merge branch 'master' into JDK-8257800
>  - Merge branch 'master' into JDK-8257800
>  - Merge branch 'master' into JDK-8257800
>  - fix a corner case. won't treat it as an error if it's dead of string.
>  - add the case -XX:CompileCommand=dontinline,*::dontinline_*" to the unittest
>  - Merge branch 'master' into JDK-8257800
>  - fix regression failure test/jdk/com/sun/jdi/EATests.java
>  - add a unittest to test over-consume situation
>  - fix building failure on Windows and chage parse_option_type to a public static member function.
>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/97628fbd...1315e19a

Looks reasonable to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1652