[jdk16] RFR: 8255763: C2: OSR miscompilation caused by invalid memory instruction placement [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.java.net
Fri Dec 18 10:58:41 UTC 2020


On Fri, 18 Dec 2020 10:11:10 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> Nice summary in the JBS issue! That looks good to me and I agree with Vladimir to do this fix in 16 and proceed with an RFE to further investigate the mentioned improvement possibilities.

Thanks for reviewing, Christian!

> src/hotspot/share/opto/block.cpp line 1229:
> 
>> 1227:       // CFGs, and by special handling in PhaseCFG::schedule_late() otherwise.
>> 1228:       if (n->is_Mach() && n->bottom_type()->has_memory() && n->in(0) != NULL) {
>> 1229:         Block *original_block = find_block_for_node(n->in(0));
> 
> `*` should be at `Block`.

Done, thanks!

-------------

PR: https://git.openjdk.java.net/jdk16/pull/22


More information about the hotspot-compiler-dev mailing list