[jdk16] RFR: 8258790: C2: Crash on empty macro node list [v2]

Tue Dec 22 08:21:56 UTC 2020

On Mon, 21 Dec 2020 22:03:10 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> The fix for 8257624 is incomplete: it doesn't cover the case when macro node array becomes empty as a result of multiple nodes removal. In such case, the out-of-bounds access still takes place (at index "-1"). 
>> 
>> Proposed fix is to adjust the index before performing "i > 0" check.    
>> 
>> Testing:
>> - [x] failing tests
>> - [ ] hs-precheckin-comp, hs-tier1, hs-tier2
>
> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reformat i-1 => i - 1

Looks good to me!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/56