RFR: 8258856: VM build without C1/C2 fails after JDK-8243205
Jie Fu
jiefu at openjdk.java.net
Wed Dec 23 06:34:56 UTC 2020
On Wed, 23 Dec 2020 05:48:10 GMT, Hao Sun <github.com+16932759+shqking at openjdk.org> wrote:
> The declaration sites for JVM flags were changed by JDK-8243205 and the
> subsequent JDK-8258074. As a result, undeclared identifier errors
> occurred while building VM without compiler1 or compiler2 feature.
>
> Making the corresponding header files included would fix it.
>
> Note that we have tested locally with this patch, build without C1/C2 succeeded on Linux X86/AArch64 machines.
Changes requested by jiefu (Committer).
src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 33:
> 31: #include "gc/shared/barrierSetNMethod.hpp"
> 32: #include "interpreter/interpreter.hpp"
> 33: #include "jvmci/jvmci_globals.hpp"
I would suggest #if INCLUDE_JVMCI for the added header file.
src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp line 30:
> 28: #include "gc/shared/cardTable.hpp"
> 29: #include "gc/shared/collectedHeap.hpp"
> 30: #include "jvmci/jvmci_globals.hpp"
This line can be removed since compiler/compiler_globals.hpp already includes jvmci_globals.hpp, right?
-------------
PR: https://git.openjdk.java.net/jdk/pull/1876
More information about the hotspot-compiler-dev
mailing list