RFR: 8258856: VM build without C1/C2 fails after JDK-8243205 [v3]

Jie Fu jiefu at openjdk.java.net
Wed Dec 23 11:05:56 UTC 2020


On Wed, 23 Dec 2020 10:09:08 GMT, Hao Sun <github.com+16932759+shqking at openjdk.org> wrote:

>> The declaration sites for JVM flags were changed by JDK-8243205 and the
>> subsequent JDK-8258074. As a result, undeclared identifier errors
>> occurred while building VM without compiler1 or compiler2 feature.
>> 
>> Making the corresponding header files included would fix it.
>> 
>> Note that we have tested locally with this patch, build without C1/C2 succeeded on Linux X86/AArch64 machines.
>
> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use JVMCI compilation condition for oopMap.cpp
>   
>   Check the compilation condition INCLUDE_JVMCI before trying to include
>   the header file, i.e. jvmci_globals.hpp, for oopMap.cpp
>   
>   Change-Id: I9885291d9f971984d83942669a22ee030722a206
>   CustomizedGitHooks: yes

LGTM
Thanks for the update.

-------------

Marked as reviewed by jiefu (Committer).

PR: https://git.openjdk.java.net/jdk/pull/1876


More information about the hotspot-compiler-dev mailing list