RFR: 8258857: Zero: non-PCH build fails after JDK-8258074

Jie Fu jiefu at openjdk.java.net
Sat Dec 26 06:42:55 UTC 2020


On Sat, 26 Dec 2020 04:42:34 GMT, Hao Sun <github.com+16932759+shqking at openjdk.org> wrote:

> Regarding the debug build, I guess it's because that flag 'pd_CICompileOSR' is not used for debug build.
> Please refer to https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/globals_shared.hpp#L84
> 
> I suppose macro 'DECLARE_PD_DEVELOPER_FLAG' is defined at line 86 for release build where flags 'pd_XXX' would be used, while this macro is defined at line 90 for debug build where flags 'pd_XXX' are not used.
> 

Yes, you are right.
The change looks reasonable to me.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1894


More information about the hotspot-compiler-dev mailing list