[11u] RFR: 8257423: [PPC64] Support -XX:-UseInlineCaches

[Doerr, Martin]

Hi Götz,


> So no issue for the downport.  It should have gone to adlc/main.cpp.

Right, that would have been another option. But it seems like only PPC needs it.



Thanks for the review!



Best regards,

Martin


From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Sent: Dienstag, 29. Dezember 2020 17:11
To: Doerr, Martin <martin.doerr at sap.com>; 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net>; jdk-updates-dev at openjdk.java.net
Cc: Langer, Christoph <christoph.langer at sap.com>
Subject: RE: [11u] RFR: 8257423: [PPC64] Support -XX:-UseInlineCaches

Hi Martin,

Both changes look good. They have only trivial adaptions.

I'is a bit strange to have an #include in an ad file,
But that was already introduced in the original file.
So no issue for the downport.  It should have gone to adlc/main.cpp.

Best regards,
  Goetz.

From: Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>
Sent: Monday, December 28, 2020 4:30 PM
To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net<mailto:hotspot-compiler-dev at openjdk.java.net>>; jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>
Cc: Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>
Subject: [11u] RFR: 8257423: [PPC64] Support -XX:-UseInlineCaches

Hi,

I'd like to backport the following PPC64 fixes to 11u together:
https://bugs.openjdk.java.net/browse/JDK-8257423
https://bugs.openjdk.java.net/browse/JDK-8257798
(2nd one is a follow-up fix for some builds)

Both changes don't apply cleanly, but are trivial to resolve:
1st one didn't apply because Universe::narrow_klass_base() was moved to CompressedKlassPointers::base() which is used in old version of MacroAssembler::instr_size_for_decode_klass_not_null.
2nd one didn't apply because of unrelated context changes.
I just had to apply the hunks manually.

Original changes:
https://github.com/openjdk/jdk/commit/1d2d9815
https://github.com/openjdk/jdk/commit/46b35acf

11u backports:
http://cr.openjdk.java.net/~mdoerr/8257423_PPC_UseInlineCaches_11u/webrev.00/
http://cr.openjdk.java.net/~mdoerr/8257798_PPC_build_11u/webrev.00/

Please review.

Best regards,
Martin