RFR: 8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert

[Vladimir Ivanov]

On Wed, 30 Dec 2020 09:09:37 GMT, Wang Huang <whuang at openjdk.org> wrote:

> $java --add-modules=jdk.incubator.vector -Xcomp -XX:CompileCommand=compileonly,TestCast16BTo2D::* -XX:+UnlockDiagnosticVMOptions -XX:+PrintIntrinsics TestCast16BTo2D
> before fixing:
>   ** not supported: arity=1 op=cast/5 vlen2=2 etype1=byte ismask=0
>                                     @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
>                                       @ 101 java.lang.Object::getClass (0 bytes) (intrinsic)
>                                       @ 109 java.lang.Object::getClass (0 bytes) (intrinsic)
>                                     @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
>                                     @ 31 jdk.internal.vm.vector.VectorSupport::load (38 bytes) (intrinsic)
>                                       @ 128 jdk.internal.vm.vector.VectorSupport::convert (39 bytes) failed to inline (intrinsic)
>                                 @ 42 jdk.internal.vm.vector.VectorSupport::store (38 bytes) (intrinsic)
> Expect:
>                                     @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
>                                       @ 101 java.lang.Object::getClass (0 bytes) (intrinsic)
>                                       @ 109 java.lang.Object::getClass (0 bytes) (intrinsic)
>                                     @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
>                                     @ 31 jdk.internal.vm.vector.VectorSupport::load (38 bytes) (intrinsic)
>                                       @ 128 jdk.internal.vm.vector.VectorSupport::convert (39 bytes) (intrinsic)
>                                 @ 42 jdk.internal.vm.vector.VectorSupport::store (38 bytes) (intrinsic)

The fix itself looks good, but I think it should be fixed in 16 as well.

Please, re-post the PR against 16.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1909