RFR: 8252049: Native memory leak in ciMethodData ctor [v5]

[David Holmes]

On 31/12/2020 8:47 am, John Paul Adrian Glaubitz wrote:
> On Tue, 8 Dec 2020 11:17:07 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
> 
>>> Marked as reviewed by kbarrett (Reviewer).
>>
>> Thanks for the reviews, Kim, Coleen, and David.
> 
> The change in 044616bd71ab82f0f67670152cecbabfee83d00c breaks the build on m68k which uses a native alignment of 16 bits despite being a 32-bit architecture as a result of the m68k SysV ABI.

Isn't m68K a zero-only platform? In which case why are these files even 
part of the build let alone runtime?

> In file included from /<<PKGBUILDDIR>>/src/hotspot/share/ci/ciEnv.hpp:35,
>                   from /<<PKGBUILDDIR>>/src/hotspot/share/ci/compilerInterface.hpp:32,
>                   from /<<PKGBUILDDIR>>/src/hotspot/share/compiler/abstractCompiler.hpp:28,
>                   from /<<PKGBUILDDIR>>/src/hotspot/share/compiler/abstractCompiler.cpp:25:
> /<<PKGBUILDDIR>>/src/hotspot/share/oops/methodData.hpp: In constructor 'MethodData::CompilerCounters::CompilerCounters()':
> /<<PKGBUILDDIR>>/src/hotspot/share/oops/methodData.hpp:1987:55: error: static assertion failed: align
>   1987 |       static_assert(sizeof(_trap_hist) % HeapWordSize == 0, "align");
>        |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> gmake[4]: *** [lib/CompileJvm.gmk:143: /<<PKGBUILDDIR>>/build/hotspot/variant-zero/libjvm/objs/abstractCompiler.o] Error 1
> gmake[3]: *** [make/Main.gmk:252: hotspot-zero-libs] Error 2
> gmake[3]: *** Waiting for unfinished jobs....
> 
> Full log: https://buildd.debian.org/status/fetch.php?pkg=openjdk-16&arch=m68k&ver=16%7E29-1&stamp=1609359094&raw=0
> 
> Any suggestion on a quick fix (before I start digging myself)?

Exclude the assertion in a zero build?

David
-----

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/1478
>