[15] RFR(XS): 8237945: CTW: C2 compilation fails with assert(just_allocated_object(alloc_ctl) == ptr) failed: most recent allo

[Christian Hagedorn]

Thank you for your review Nils!

Best regards,
Christian

On 12.02.20 11:51, Nils Eliasson wrote:
> +1
> 
> Best regards,
> Nils
> 
> On 2020-02-10 14:57, Tobias Hartmann wrote:
>> Hi Christian,
>>
>> looks good.
>>
>> Best regards,
>> Tobias
>>
>> On 10.02.20 14:36, Christian Hagedorn wrote:
>>> Hi
>>>
>>> Please review the following patch:
>>> https://bugs.openjdk.java.net/browse/JDK-8237945
>>> http://cr.openjdk.java.net/~chagedorn/8237945/webrev.00/
>>>
>>> The assert is too strong as seen in the test case. The most recent 
>>> allocation is the one from the
>>> if-branch whose memory state is not merged back for the array copy 
>>> due to the return. Therefore, the
>>> bailout checks in LibraryCallKit::tightly_coupled_allocation() about 
>>> the memory pass and the
>>> assertion fails afterwards.
>>>
>>> Thank you!
>>>
>>> Best regards,
>>> Christian
>