[15] RFR: 8237894: CTW: C1 compilation fails with assert(x->type()->tag() == f->type()->tag()) failed: should have same type

[Aleksey Shipilev]

On 2/12/20 12:07 PM, Jamsheed C M wrote:
> Thank you for the feedback Aleksey. I agree, updated webrev in place[1].
> [1]http://cr.openjdk.java.net/~jcm/8237894/webrev/

Looks good! I have not run any extensive testing on this.

But now I have second thoughts. Do we foresee any performance troubles from not GVN'ing null
constants in C1, though? Maybe we should err on the side of caution and hash in the type as well?
That would probably be awkward for subtypes. Maybe we should relax the assert for null constants
instead? This assumes the type mismatch is not catastrophic.

-- 
Thanks,
-Aleksey