RFR(M): 8203883: Remove State from InvocationCounters

[Claes Redestad]

Hi,

I like it!

+ private:              // bit no: |29  1|  0  |
+  uint _counter;       // format: [count|carry|

Shouldn't the 29 still be 31?

All overloads of disable_compilation() is now a no-op - can these
be removed?

With only a carry bit left did you consider flipping the bit order
(highest bit as carry)? Probably doesn't matter for performance, but
might simplify some code (less shifts, count++, ..)

Thanks!

/Claes

On 2020-02-12 08:58, Nils Eliasson wrote:
> Hi,
> 
> This is a clean-up of the invocation counters. The original observation 
> is that the action() method on invocationCounter is never used, which 
> means the actions are never accessed. There are also init-values, but 
> they are always the same regardless of state, so they can be removed 
> too. And when both the action and init values are gone, the state has no 
> use anymore and can be removed too. This simplifies the 
> InvocationCounter a lot.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8203883
> Webrev: http://cr.openjdk.java.net/~neliasso/8203883/webrev.02
> 
> Please review,
> 
> Nils Eliasson
> 
> 
>