[8u] RFR: 8134579: [TESTBUG] Some bmi tests fail if can_access_local_variables is on.

[Andrew John Hughes]

On 02/10/2019 11:17, Severin Gehwolf wrote:
> Hi,
> 
> Could I get a review of this OpenJDK 8u test-fix, please? We are seeing
> occasional test failures for LZcntTestI.java and/or LZcntTestL.java
> when running OpenJDK 8u tier1 tests. Backporting this change from JDK 9
> fixes the issue. The JDK 9 patch didn't apply cleanly. Modifications
> I've done are:
> 
>  * Record AddnTest{I,L}.java => AndnTest{L,I}.java as a rename.
>  * Manually removed AddnTest{I,L}.java tests as the removal rejected.
>    This was done part of the rename (hg mv -A source dest)
>  * Kept @library and @run definitions of AndnTest{I,L}.java as they
>    were, modulo test name (last argument).
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8134579
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8134579/jdk8/01/webrev/
> 
> Testing: OpenJDK 8u tier1 tests on Linux x86_64 (release/fastdebug).
> Relevant test(s) fails prior, passes after.
> 
> Thoughts?
> 
> Thanks,
> Severin
> 

Sounds like a bit of additional admin rather than any code change from
the original. Approved for 8u.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew