RFR: 8239110: Zero VM build fails after JDK-8203883

jiefu(傅杰) jiefu at tencent.com
Sat Feb 15 09:49:23 UTC 2020


Thanks Andrew for your review and comments.
Fixed and pushed.

Best regards,
Jie

On 2020/2/15, 4:58 PM, "Andrew Haley" <aph at redhat.com> wrote:

    On 2/15/20 2:00 AM, jiefu(傅杰) wrote:
    
    > JBS:    https://bugs.openjdk.java.net/browse/JDK-8239110
    > Webrev: http://cr.openjdk.java.net/~jiefu/8239110/webrev.00/
    
    This is fine, but those lines are very long. Please break them somewhere,
    perhaps like this:
    
      InvocationCounter::InterpreterBackwardBranchLimit =
        (int)((int64_t)CompileThreshold
              * (OnStackReplacePercentage - InterpreterProfilePercentage) / 100);
    
    You don't need another review.
    
    -- 
    Andrew Haley  (he/him)
    Java Platform Lead Engineer
    Red Hat UK Ltd. <https://www.redhat.com>
    https://keybase.io/andrewhaley
    EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
    
    
    



More information about the hotspot-compiler-dev mailing list