[15]RFR: 8238356: CodeHeap::blob_count() overestimates the number of blobs

[Schmidt, Lutz]

Hi all, 

the fix is good. Sorry for blocking the push. And thank you, Rahul, for discovering and fixing the blob counter. 

Thanks,
Lutz

On 17.02.20, 11:07, "Schmidt, Lutz" <lutz.schmidt at sap.com> wrote:

    Hi all, 
    
    I'm not sure this fix will do the trick once and for all. Things are a bit more complicated. I'm sending this heads up without detailed explanation to prevent a premature push. Please stand by, I'll provide the explanation asap.
    
    Thanks for your patience!
    Lutz
    
    On 17.02.20, 10:16, "hotspot-compiler-dev on behalf of Aleksey Shipilev" <hotspot-compiler-dev-bounces at openjdk.java.net on behalf of shade at redhat.com> wrote:
    
        On 2/17/20 9:12 AM, Rahul Raghavan wrote:
        > [src/hotspot/share/memory/heap.cpp]
        >   void CodeHeap::add_to_freelist(HeapBlock* a) {
        >     FreeBlock* b = (FreeBlock*)a;
        >     size_t bseg = segment_for(b);
        >     _freelist_length++;
        > 
        > + _blob_count--;
        > + assert(_blob_count >= 0, "sanity");
        > +
        >     assert(b != _freelist, "cannot be removed twice");
        
        Looks fine to me (obviously).
        
        -- 
        Thanks,
        -Aleksey