RFR(S): 8238723: yank_alloc_node must remove membar

[Nils Eliasson]

Hi,

Thanks for the feedback.

Yes, the membar should be removed too, and membar::remove gets the job 
done, as Tobias suggested.

I changed the removal to only look for MembarStoreStore since the 
InitializeNode is already removed, and I can't come up with a scenario 
where I would find an AddNode there.

http://cr.openjdk.java.net/~neliasso/8238723/webrev.02/

Best regards,

Nils Eliasson

On 2020-02-18 14:01, Tobias Hartmann wrote:
> On 18.02.20 13:32, Vladimir Ivanov wrote:
>> In case of MemBar I assume you are handling the precedence edge (MemBarNode::Precedent). Why do you
>> replace it with TOP? I assume you want to eliminate the barrier, but I don't see how it helps.
> Actually, you might want to use MemBarNode::remove.
>
> Best regards,
> Tobias