RFR; 8240223: Use consistent predicate order in and with PhaseIdealLoop::find_predicate
Tobias Hartmann
tobias.hartmann at oracle.com
Fri Feb 28 13:03:08 UTC 2020
Hi Stefan,
looks good to me. Since you are touching that code anyway, could you please remove the whitespace
after NULL in loopnode.cpp lines 2661, 2668, 2674? (no new webrev required)?
Thanks,
Tobias
On 28.02.20 12:12, Stefan Karlsson wrote:
> Hi all,
>
> Please review this patch to make the predicate search order consistent in
> PhaseIdealLoop::find_predicate and some of its usages.
>
> https://cr.openjdk.java.net/~stefank/8240223/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8240223
>
> The code wasn't broken before, but making the search order consistent, make it easier for the casual
> reader to more easily understand the code related to the loop predicates.
>
> Minimal testing done, will run through tier1-3
>
> Thanks,
> StefanK
More information about the hotspot-compiler-dev
mailing list