RFR(T): 8239931: [win][x86] vtable stub generation: assert failure (code size estimate) follow-up

Schmidt, Lutz lutz.schmidt at sap.com
Fri Feb 28 15:39:26 UTC 2020


Hi Martin, 
thanks for the Review! Pushed.
And sorry for the late response. Your review was hidden in my inbox mess. But now I'm back to normal. __
Regards, Lutz

On 26.02.20, 18:14, "Doerr, Martin" <martin.doerr at sap.com> wrote:

    Hi Lutz,
    
    looks good and trivial.
    
    Best regards,
    Martin
    
    
    > -----Original Message-----
    > From: hotspot-compiler-dev <hotspot-compiler-dev-
    > bounces at openjdk.java.net> On Behalf Of Schmidt, Lutz
    > Sent: Mittwoch, 26. Februar 2020 11:33
    > To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-
    > dev at openjdk.java.net>
    > Subject: Re: RFR(T): 8239931: [win][x86] vtable stub generation:
    > assert failure (code size estimate) follow-up
    > 
    > The jdk/submit tests are in:
    > 
    > Job: mach5-one-lucy-JDK-8239931-20200225-1721-8982626
    > 
    > BuildId: 2020-02-25-1720376.lutz.schmidt.source
    > 
    > No failed tests
    > 
    > Tasks Summary
    > 
    > UNABLE_TO_RUN: 0
    > PASSED: 79
    > FAILED: 0
    > NA: 0
    > NOTHING_TO_RUN: 0
    > EXECUTED_WITH_FAILURE: 0
    > HARNESS_ERROR: 0
    > KILLED: 0
    > 
    > Thanks,
    > Lutz
    > 
    > 
    > On 25.02.20, 19:15, "Schmidt, Lutz" <lutz.schmidt at sap.com> wrote:
    > 
    >     All,
    > 
    >     please review this change to increase the size estimate (for a cmpl
    > instruction) in the vtable stub generator. I would categorize this change as
    > trivial.
    > 
    >     This fix is a follow-up to JDK-8239456.
    > 
    >     Testing: SAP-internal nightly tests (which showed the assert failure)
    >              jdk/submit (pending)
    > 
    >     Bug:    https://bugs.openjdk.java.net/browse/JDK-8239931
    >     Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8239931.00/
    > 
    >     Thanks,
    >     Lutz
    > 
    > 
    
    



More information about the hotspot-compiler-dev mailing list