[15]RFR: 8235995: Remove src/jdk.internal.vm.compiler/.mx.graal directory

[Vladimir Kozlov]

On 2/28/20 12:10 PM, Dean Long wrote:
> Hi Vladimir,
> 
> On 2/28/20 12:01 PM, Vladimir Kozlov wrote:
>> :( I was late
>>
>> Originally we kept this directory for IDE support of Graal in JDK.
>>
> 
> So where did this directory come from?  I couldn't find it in upstream Graal.

It was copy of mx.graal in OpenJDK Graal back in JDK9 [1] when we integrated Graal into JDK 9 [2].
Currently it is graal/compiler/mx.compiler/ directory in GraalVM.

[1] http://hg.openjdk.java.net/graal/graal-compiler/file/964f28c04d7b/mx.graal
[2] 8166417: Integrate Graal-core into JDK for AOT compiler

> 
>> And I use this directory in Metropolis for EA to keep some mx script files. I will keep repo there.
>>
> 
> If you're keeping it in Metropolis, you may or may not need this change:
> 
> http://cr.openjdk.java.net/~tschatzl/8235907/webrev/src/jdk.internal.vm.compiler/.mx.graal/sanitycheck.py.cdiff.html

Okay. Good to know.

Thanks,
Vladimir

>> On other hand we can resurrect it later if needed:
>> https://bugs.openjdk.java.net/browse/JDK-8189600
>>
> OK.
> 
> dl
> 
>> Vladimir K
>>
>> On 2/26/20 9:54 PM, Dean Long wrote:
>>> Yes, testing looks good, and changes look trivial.  Go ahead and push.
>>>
>>> dl
>>>
>>> On 2/26/20 9:47 PM, Rahul Raghavan wrote:
>>>> Thank you Dean for checking this.
>>>>
>>>> Found no issues with usual hs-tier1 - 3, hs-precheckin-comp testing.
>>>> Also no issues with hs-tier3/4/5-graal testing.
>>>> Hope the testing done is okay!?
>>>>
>>>> Thanks,
>>>> Rahul
>>>>
>>>> On 26/02/20 1:36 pm, Dean Long wrote:
>>>>> Looks good.  What testing did you do?
>>>>>
>>>>> dl
>>>>>
>>>>> On 2/25/20 5:47 AM, Rahul Raghavan wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Please review the following patch to remove
>>>>>>   'src/jdk.internal.vm.compiler/.mx.graal' directory and files,
>>>>>>   reported as added by mistake and is not part of upstream Graal.
>>>>>>
>>>>>> <webrev> - http://cr.openjdk.java.net/~rraghavan/8235995/webrev.00/
>>>>>> <JBS> - https://bugs.openjdk.java.net/browse/JDK-8235995
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Rahul
>>>>>
>>>
>