RFR(S): 8236759: ShouldNotReachHere in PhaseIdealLoop::verify_strip_mined_scheduling
Tobias Hartmann
tobias.hartmann at oracle.com
Tue Jan 14 15:29:30 UTC 2020
Hi Roland,
On 13.01.20 13:30, Roland Westrelin wrote:
>> Just wondering why you need the checks in line 1487? Isn't in->is_OuterStripMinedLoop() sufficient
>> since we should never schedule a data node in the outer strip mined loop?
>
> It could be top too. Also I guess, I'm becoming paranoid about little
> things going wrong with strip mining...
Fair enough. Looks good to me but please add a brief comment (something like "should not schedule a
data node in the outer strip mined loop") before pushing.
Thanks,
Tobias
More information about the hotspot-compiler-dev
mailing list