RFR(S): 8237007: Shenandoah: assert(_base == Tuple) failure during C2 compilation

Roman Kennke rkennke at redhat.com
Wed Jan 15 09:44:10 UTC 2020


Hi Roland,

>> It looks ok to me. I'd probably add case Op_CMove cases to the switch
>> instead.
> 
> Thanks for looking at this. I would have to list all variants in the
> switch:
> 
> CMoveD
> CMoveVD
> CMoveF
> CMoveVF
> CMoveI
> CMoveL
> CMoveP
> CMoveN
> 
> That doesn't seem better to me and is quite error prone too.

Yes, true. It's the case for Op_Load* above too, and less pronounced for
Div, Mod, etc. I don't have a strong preference either way, your call.

Patch is good.

Thank you!
Roman



More information about the hotspot-compiler-dev mailing list