RFR(S) : 8237787 : rewrite vmTestbase/vm/compiler/CodeCacheInfo* from shell to java

Igor Ignatyev igor.ignatyev at oracle.com
Thu Jan 30 00:49:13 UTC 2020


> @list
> can I get a 2nd Review?
ping?

-- Igor

> On Jan 27, 2020, at 3:39 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> @Katya,
> 
> thank you!
> 
> @list
> can I get a 2nd Review?
> 
> -- Igor
> 
>> On Jan 24, 2020, at 3:26 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>> 
>> Seems to be good now.
>> 
>> thanks,
>> -katya
>> 
>> On 1/24/20 3:06 PM, Igor Ignatyev wrote:
>>> no, you are right. it seems I uploaded not the latest version of my patch. fixed and uploaded .01 which has -Xcomp -- http://cr.openjdk.java.net/~iignatyev//8237787/webrev.01
>>> -- Igor
>>>> On Jan 24, 2020, at 8:18 AM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com <mailto:ekaterina.pavlova at oracle.com>> wrote:
>>>> 
>>>> On 1/23/20 2:21 PM, Igor Ignatyev wrote:
>>>>> http://cr.openjdk.java.net/~iignatyev//8237787/webrev.00
>>>>>> 177 lines changed: 56 ins; 117 del; 4 mod; 7
>>>>> Hi all,
>>>>> could you please review the patch which rewrites vmTestbase/vm/compiler/CodeCacheInfo and CodeCacheInfoOnCompilation tests from shell to java?
>>>>> the only difference b/w java and shell versions are:
>>>>> - instead of skipping execution if there isn't -Xcomp, CodeCacheInfoOnCompilation adds -Xcomp to command line
>>>> 
>>>> Igor, I don't see -Xcomp is added. Am I missing something?
>>>> 
>>>>> - instead of checking the value of SegmentedCodeCache flag, CodeCacheInfo runs two cases w/ +SegmentedCodeCache and w/ -SegmentedCodeCache
>>>>> webrev: http://cr.openjdk.java.net/~iignatyev//8237787/webrev.00
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8237787
>>>>> testing: the changed tests on linux-x64, windows-x64, and macosx-x64
>>>>> Thanks,
>>>>> -- Igor
>>>> 
>> 
> 



More information about the hotspot-compiler-dev mailing list