[16] RFR(T) 8005088: remove unused NativeInstruction::test methods

Igor Ignatyev igor.ignatyev at oracle.com
Wed Jul 1 03:15:11 UTC 2020


Hi Vladimir,

the years in copyright notices should be updated, otherwise looks good to me, thanks for taking care of it.

-- Igor

> On Jun 30, 2020, at 8:12 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> https://cr.openjdk.java.net/~kvn/8005088/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8005088
> 
> Only SPARC implemented NativeInstruction::test() methods [1]. And it is was removed in JDK 15 with SPARC port.
> 
> I think we can remove them on other platforms where they are not implemented.
> If someone wants to recreate test, they should do that as gtest test(s).
> 
> Thanks,
> Vladimir
> 
> [1] https://hg.openjdk.java.net/jdk/jdk14/file/6c954123ee8d/src/hotspot/cpu/sparc/nativeInst_sparc.cpp#l356



More information about the hotspot-compiler-dev mailing list