8248336: AArch64: C2: offset overflow in BoxLockNode::emit

Andrew Dinn adinn at redhat.com
Thu Jul 2 08:04:12 UTC 2020


On 25/06/2020 17:48, Andrew Haley wrote:
> On 25/06/2020 17:31, Andrew Haley wrote:
>> BoxLockNode::emit only allows a 12-bit offset from register SP to the
>> stack slot that contains the inflated lock. Rather amazingly we've
>> never seen this fail in production, but in theory a BoxLockNode can be
>> anywhere in the stack frame.
>>
>> I have once seen this fail in test code, but it is very hard to
>> reproduce.
> 
> http://cr.openjdk.java.net/~aph/8248336/
Sorry, I checked the patch when you posted the webrev and I thought I
had posted an ack but clearly did not.

This is fine.

regards,


Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill



More information about the hotspot-compiler-dev mailing list