RFR(S): 8245021: Add method 'remove_if_existing' to growableArray.

[Nils Eliasson]

Still looking good!

Best regards,
Nil


On 2020-07-03 17:09, Patric Hedlin wrote:
> Thanks for reviewing Nils.
>
> Care to take another look?
>
> I moved this to 16 (after JDK-8247755). Added some refactoring to new 
> webrev (refreshed).
>
> /Patric
>
> On 2020-06-02 09:51, Nils Eliasson wrote:
>> +1
>>
>> Best regards,
>> Nils Eliasson
>>
>> On 2020-05-19 11:33, Tobias Hartmann wrote:
>>> Hi Patric,
>>>
>>> Looks good to me but please add brackets around the for loop.
>>>
>>> Also, there are some more cases of this code pattern. For example,
>>> JvmtiPendingMonitors::destroy/exit and
>>> ShenandoahBarrierSetC2State::remove_enqueue_barrier/remove_load_reference_barrier. 
>>>
>>>
>>> Best regards,
>>> Tobias
>>>
>>> On 18.05.20 22:37, Patric Hedlin wrote:
>>>> Dear all,
>>>>
>>>> I would like to ask for help to review the following change/update:
>>>>
>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8245021
>>>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8245021/
>>>>
>>>>
>>>> 8245021: Add method 'remove_if_existing' to growableArray.
>>>>
>>>> Minor improvement to simplify the code pattern "if contains then 
>>>> remove" found in a few places (in
>>>> "compile.hpp").
>>>>
>>>>
>>>> Testing: hs-tier1-3
>>>>
>>>>
>>>> Best regards,
>>>> Patric