[15] RFR(T) 8247527: serviceability/dcmd/gc/HeapDumpCompressedTest.java fails with Graal + ZGC

[Vladimir Kozlov]

Thank you, David

Vladimir K

On 7/3/20 3:18 PM, David Holmes wrote:
> On 4/07/2020 4:30 am, Vladimir Kozlov wrote:
>> Thank you, David, for looking on changes.
>>
>> I will remember to update tests. I filed RFE 8248815 [1] for tracking.
>>
>> Can you approve this fix now?
> 
> Yes - thanks.
> 
> David
> 
>> Thanks,
>> Vladimir K
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8248815
>>
>> On 7/2/20 10:09 PM, David Holmes wrote:
>>> Hi Igor,
>>>
>>> On 3/07/2020 12:59 pm, Igor Ignatyev wrote:
>>>> Hi David,
>>>>
>>>> it's in my todo list to improve this situation and have vm.gc.X to take selected JIT into account; and update 
>>>> existing (>200) occurrences of 'vm.gc.X & !vm.graal.enabled'
>>>
>>> 200+ ouch! :(
>>>
>>> I guess this fix doesn't make the situation any worse in a practical sense.
>>>
>>> Thanks,
>>> David
>>> -----
>>>
>>>> -- Igor
>>>>
>>>>> On Jul 2, 2020, at 7:25 PM, David Holmes <david.holmes at oracle.com> wrote:
>>>>>
>>>>> Hi Vladimir,
>>>>>
>>>>> On 3/07/2020 12:02 pm, Vladimir Kozlov wrote:
>>>>>> https://cr.openjdk.java.net/~kvn/8247527/webrev.00/
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8247527
>>>>>> Test should have @requires which excludes running Graal with GC which it does not support.
>>>>>
>>>>> I find it somewhat disturbing that a generic test has to know about the limitations between GCs and Graal!
>>>>>
>>>>> I would have been more inclined to just exclude this test when running with Graal, even if that theoretically 
>>>>> reduced the test coverage in a ting way.
>>>>>
>>>>> If/When Graal supports these other GCs who will remember to re-enable these test cases?
>>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>>> Testing: hs-tier1,hs-tier4-graal
>>>>>> Thanks,
>>>>>> Vladimir
>>>>