RFR(XS) 8248568: compiler/c2/TestBit.java failed: 'test' missing from stdout/stderr

Boris Ulasevich boris.ulasevich at bell-sw.com
Mon Jul 6 09:17:54 UTC 2020


Thank you Vladimir.

May I consider the change trivial or should I ask for more reviews?

regards,
Boris

On 03.07.2020 00:45, Vladimir Kozlov wrote:
> Looks good.
>
> Thanks,
> Vladimir
>
> On 7/2/20 2:29 PM, Boris Ulasevich wrote:
>> Hi Vladimir,
>>
>> Thank you. I applied your suggestions. On our machines jtreg runs well.
>> Update: http://cr.openjdk.java.net/~bulasevich/8248568/webrev.01
>>
>> regards,
>> Boris
>>
>> On Thu, Jul 2, 2020 at 9:54 PM Vladimir Kozlov 
>> <vladimir.kozlov at oracle.com>
>> wrote:
>>
>>> Good.
>>>
>>> You may also replace next requirements:
>>>
>>> vm.flavor == "server" & !vm.graal.enabled
>>>
>>> with one:
>>>
>>> vm.compiler2.enabled
>>>
>>> Graal and C2 are mutually exclusive.
>>>
>>> May be also run processes without C1 by switching off Tiered 
>>> Compilation.
>>>
>>> And instead of:
>>> @run main/othervm compiler.c2.TestBit
>>>
>>> use:
>>> @run driver compiler.c2.TestBit
>>>
>>> Because you launching separate processes.
>>>
>>> Please, test changes with jtreg testing.
>>>
>>> Thanks,
>>> Vladimir K
>>>
>>> On 7/2/20 11:13 AM, Boris Ulasevich wrote:
>>>> Hi,
>>>>
>>>> Please review a one-line change: adding -Xbatch option to recently
>>>> introduced test to get a more predictable PrintOptoAssembly output.
>>>>
>>>> http://cr.openjdk.java.net/~bulasevich/8248568/webrev.00
>>>> http://bugs.openjdk.java.net/browse/JDK-8248568
>>>>
>>>> thanks,
>>>> Boris
>>>



More information about the hotspot-compiler-dev mailing list