RFR(XS) 8247695: [PPC, S390]: compiler/intrinsics/math/TestFpMinMaxIntrinsics.java fails

[Reingruber, Richard]

Hi Lutz,

thanks for your Review. I'll push after the weekend.

Cheers, Richard.

-----Original Message-----
From: Schmidt, Lutz <lutz.schmidt at sap.com> 
Sent: Freitag, 10. Juli 2020 12:13
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Reingruber, Richard <richard.reingruber at sap.com>; hotspot-compiler-dev at openjdk.java.net
Subject: Re: [CAUTION] RE: [CAUTION] RFR(XS) 8247695: [PPC, S390]: compiler/intrinsics/math/TestFpMinMaxIntrinsics.java fails

Hi Richard, 

your change looks good to me. Reviewed.

We had the change active in our test landscape for quite a few days now. It solves the issue and shows no negative side effects. 

Thanks for fixing.
Lutz

On 02.07.20, 18:45, "hotspot-compiler-dev on behalf of Lindenmaier, Goetz" <hotspot-compiler-dev-retn at openjdk.java.net on behalf of goetz.lindenmaier at sap.com> wrote:

    Hi Richard, 

    I had a look at your change, looks good.  Reviewed.
    Thanks for fixing this.

    Best regards,
      Goetz.


    > -----Original Message-----
    > From: hotspot-compiler-dev <hotspot-compiler-dev-retn at openjdk.java.net>
    > On Behalf Of Reingruber, Richard
    > Sent: Thursday, July 2, 2020 4:05 PM
    > To: hotspot-compiler-dev at openjdk.java.net
    > Subject: [CAUTION] RFR(XS) 8247695: [PPC, S390]:
    > compiler/intrinsics/math/TestFpMinMaxIntrinsics.java fails
    > 
    > Hi,
    > 
    > could I please get reviews for this small bugfix which adds support for AbsL
    > nodes to the C2
    > backends on PPC and S390?
    > 
    > Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8247695/webrev.0/
    > Bug:    https://bugs.openjdk.java.net/browse/JDK-8247695
    > 
    > The patch successfully passes regression testing @SAP which includes JCK
    > and JTREG tests, also in
    > Xcomp mode, SPECjvm2008, SPECjbb2015, Renaissance Suite, SAP specific
    > tests with fastdebug and
    > release builds.
    > 
    > Thanks, Richard.