RFR [15] : 8249019 : clean up FileInstaller $test.src $cwd in vmTestbase_vm_compiler tests

Igor Ignatyev igor.ignatyev at oracle.com
Fri Jul 10 18:51:11 UTC 2020


thanks Vladimir, pushed to jdk/jdk15.

-- Igor

> On Jul 10, 2020, at 11:09 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Reviewed.
> 
> Vladimir K
> 
> On 7/10/20 9:24 AM, igor.ignatyev at oracle.com wrote:
>> Thanks Katya.
>> Can I get a (R)eview?
>> — Igor
>>> On Jul 9, 2020, at 1:44 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>>> 
>>> Looks good,
>>> 
>>> -katya
>>> 
>>> 
>>>> On 7/9/20 1:34 PM, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.net/~iignatyev//8249019/webrev.00
>>>>> 269 lines changed: 0 ins; 163 del; 106 mod
>>>> Hi all,
>>>> could you please review the patch which removes `FileInstaller . .` jtreg action from vmTestbase_vm_compiler tests?
>>>> from the main issue(8204985):
>>>>> all vmTestbase tests have '@run driver jdk.test.lib.FileInstaller . .' to mimic old test harness behavior and copy all files from a test source directory to a current work directory. some tests depend on this step, so we need 1st identify such tests and then either rewrite them not to have this dependency or leave FileInstaller only in these tests.
>>>> some of vmTestbase_vm_compiler tests depend on FileInstaller, so they are left intact and will be updated separately.
>>>> testing: :vmTestbase_vm_compiler on linux-x64
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8249019
>>>> webrev: http://cr.openjdk.java.net/~iignatyev//8249019/webrev.00
>>>> Thanks,
>>>> -- Igor
>>> 



More information about the hotspot-compiler-dev mailing list