[15] RFR(T) : 8249678 : @ignore should be used instead of ProblemList for 8158860, 8163894, 8193479, 8194310

Igor Ignatyev igor.ignatyev at oracle.com
Fri Jul 17 17:51:26 UTC 2020


http://cr.openjdk.java.net/~iignatyev//8249678/webrev.00
> 10 lines changed: 4 ins; 5 del; 1 mod;

Hi all,

could you please review this trivial clean up which replaces ProblemList entires w/ @ignore tag in tests which aren't runnable?

- compiler/jvmci/compilerToVM/GetResolvedJavaTypeTest.java isn't runnable due to 8158860
- compiler/jvmci/compilerToVM/InvalidateInstalledCodeTest.java isn't runnable due to 8163894 
- compiler/codegen/Test6896617.java isn't runnable due to 8193479 
- compiler/c2/Test6852078.java isn't runnable due to 8194310 

from main bug(8249618):
> although ProblemList and @ignore achieve the same end result (test exclusion), their server different goals and have slightly different meanings, simplified @ignore should be used to exclude useless or harmful tests, and ProblemList in all other cases (see yet-not-integrated `ProblemListing or `@ignore`-ing a Test` section of dev guide, PR -- https://github.com/openjdk/guide/pull/21 for more details). 
> 
> due to different reasons, this hasn't been always followed and some currently @ignore-d tests should rather be ProblemList-ed, and some of ProblemList-ed should be @ignore-d, this issue is to clean up the current state in a hope that this will reduce further confusion. 


JBS: https://bugs.openjdk.java.net/browse/JDK-8249678
webrev: http://cr.openjdk.java.net/~iignatyev//8249678/webrev.00

Thanks,
-- Igor

8249618 : https://bugs.openjdk.java.net/browse/JDK-8249618

8158860 : https://bugs.openjdk.java.net/browse/JDK-8158860
8163894 : https://bugs.openjdk.java.net/browse/JDK-8163894
8193479 : https://bugs.openjdk.java.net/browse/JDK-8193479
8194310 : https://bugs.openjdk.java.net/browse/JDK-8194310





More information about the hotspot-compiler-dev mailing list