[15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

Vladimir Kozlov vladimir.kozlov at oracle.com
Sat Jul 18 17:09:40 UTC 2020


Good.

Thanks,
Vladimir

On 7/17/20 8:54 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev/8249697/webrev.00/
>> 7 lines changed: 4 ins; 0 del; 3 mod;
> 
> 
> Hi all,
> 
> could you please review this small and trivial patch for java/lang/invoke/RicochetTest.java test?
> from JBS:
>> a run of java/lang/invoke/RicochetTest.java w/ MAX_ARITY=255 was removed from all configurations by JDK-7049122, yet the problem manifests itself only w/ Xcomp. as now we have @requires to filter out tests from certain configurations, the test can be updated to run MAX_ARITY=255 in all configs but Xcomp.
> 
> the patch splits the test into two subtests, each one w/ one @run, and use @requires to exclude one w/ MAX_ARITY=255 from execution if Xcomp flag is used.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8249697
> webrev: http://cr.openjdk.java.net/~iignatyev/8249697/webrev.00/
> testing: java/lang/invoke/RicochetTest.java on {linux,windows,macos}-x64 w/ and w/o -Xcomp; Xcomp runs, as expected, had only 1 test run
> 
> Thanks,
> -- Igor
> 
> JDK-7049122 : https://bugs.openjdk.java.net/browse/JDK-7049122
> 


More information about the hotspot-compiler-dev mailing list