[15] RFR: 8242895: failed: sanity at src/hotspot/share/opto/escape.cpp:2361

Jamsheed C M jamsheed.c.m at oracle.com
Mon Jul 20 13:30:32 UTC 2020


Hi Tobias,

Thank you for the review and the feedback.

Revised webrev: http://cr.openjdk.java.net/~jcm/8242895/webrev_fix_EA.03/

Best regards,

Jamsheed

On 20/07/2020 15:20, Tobias Hartmann wrote:
> Hi Jamsheed,
>
> On 20.07.20 09:52, Jamsheed C M wrote:
>> http://cr.openjdk.java.net/~jcm/8242895/webrev_fix_EA.02/
> Looks good to me too. Some style comments:
>
> escape.cpp:
> - line 2250: Maybe rename to "is_captured_store_address" or something similar
> - line 2254: just move _igvn->type into the assert
> - line 2257: wrong indentation
> - line 2996: "assocaited" -> "associated"
>
> Best regards,
> Tobias


More information about the hotspot-compiler-dev mailing list