RFR: 8249888: failure to create a libgraal JavaVM should result in a VM crash

Doug Simon doug.simon at oracle.com
Wed Jul 22 20:56:57 UTC 2020


Thanks Tom.

-Doug

> On 22 Jul 2020, at 20:04, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
> 
> Looks good.
> 
> tom
> 
> Doug Simon wrote on 7/22/20 8:53 AM:
>> Please review this enhancement which improves the debuggability of certain libgraal isolate creation issues.
>> BUG:
>> https://bugs.openjdk.java.net/browse/JDK-8249888
>> PATCH:
>> diff -r 8995e9efdee7 src/hotspot/share/jvmci/jvmciRuntime.cpp
>> --- a/src/hotspot/share/jvmci/jvmciRuntime.cpp	Wed Jul 22 17:08:01 2020 +0200
>> +++ b/src/hotspot/share/jvmci/jvmciRuntime.cpp	Wed Jul 22 17:41:06 2020 +0200
>> @@ -800,7 +800,7 @@
>>        JNI_CreateJavaVM = CAST_TO_FN_PTR(JNI_CreateJavaVM_t, os::dll_lookup(sl_handle, "JNI_CreateJavaVM"));
>>      if (JNI_CreateJavaVM == NULL) {
>> -      vm_exit_during_initialization("Unable to find JNI_CreateJavaVM", sl_path);
>> +      fatal("Unable to find JNI_CreateJavaVM in %s", sl_path);
>>      }
>>        ResourceMark rm;
>> @@ -835,7 +835,7 @@
>>        JVMCI_event_1("created JavaVM[%ld]@" PTR_FORMAT " for JVMCI runtime %d", javaVM_id, p2i(javaVM), _id);
>>        return env;
>>      } else {
>> -      vm_exit_during_initialization(err_msg("JNI_CreateJavaVM failed with return value %d", result), sl_path);
>> +      fatal("JNI_CreateJavaVM failed with return value %d", result);
>>      }
>>    }
>>    return NULL;
>> -Doug



More information about the hotspot-compiler-dev mailing list