RFR: 8250548: libgraal can deadlock in -Xcomp mode

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Jul 24 17:23:58 UTC 2020


+1

Thanks,
Vladimir K

On 7/24/20 9:54 AM, Tom Rodriguez wrote:
> Looks good.
> 
> tom
> 
> Doug Simon wrote on 7/24/20 9:53 AM:
>> Please review this bug fix for a deadlock in libgraal under Xcomp.
>>
>> BUG:
>> https://bugs.openjdk.java.net/browse/JDK-8250548
>>
>> PATCH:
>>
>> diff -r 1f37a5cd6afc src/hotspot/share/compiler/compileBroker.cpp
>> --- a/src/hotspot/share/compiler/compileBroker.cpp      Fri Jul 24 11:00:50 2020 -0400
>> +++ b/src/hotspot/share/compiler/compileBroker.cpp      Fri Jul 24 18:52:30 2020 +0200
>> @@ -1655,7 +1655,7 @@
>>     bool free_task;
>>   #if INCLUDE_JVMCI
>>     AbstractCompiler* comp = compiler(task->comp_level());
>> -  if (!UseJVMCINativeLibrary && comp->is_jvmci() && !task->should_wait_for_compilation()) {
>> +  if (comp->is_jvmci() && !task->should_wait_for_compilation()) {
>>       // It may return before compilation is completed.
>>       free_task = wait_for_jvmci_completion((JVMCICompiler*) comp, task, thread);
>>     } else
>>
>>
>> Testing: hs-tier1,hs-tier2,hs-tier3-graal
>>
>> -Doug
>>


More information about the hotspot-compiler-dev mailing list