[aarch64-port-dev ] RFR(S): 8248676: AArch64: Add workaround for LITable constructor
Andrew Haley
aph at redhat.com
Sat Jul 25 15:30:26 UTC 2020
On 24/07/2020 17:02, Ludovic Henry wrote:
> Are you saying that you would like this change to land into
> `aarch64-port/jdk-windows` before getting into jdk/jdk? This change
> doesn't strike me as windows-aarch64 specific and is in line with
> general removal of GCC-specific code (similarly to the LP64 vs
> LLP64, or JDK-8248666).
>
> Webrev: http://cr.openjdk.java.net/~burban/luhenry/8248676/webrev.01
You make a good point. I didn't want to get integer type cleanups
mixed up with the Windows import, so I wanted to do them first.
I think there was a general feeling, expressed by Dalibor, the leader
of the Porters' Group, that the Windows changes should be integrated
into the http://hg.openjdk.java.net/aarch64-port/jdk-windows/ tree.
This change is marginal, IMO. Clearly it's a GCC-ism, so I won't
refuse it being cleaned up in mainline if you want.
But I think we should now move to integrating all of your Windows-
specific changes in the jdk-windows tree and then we'll put together a
Big Windows Patch and push that to mainline. I don't think it'll take
long. Let's just get it done!
--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the hotspot-compiler-dev
mailing list