RFR(T) : 8250738 : C2Compiler::is_intrinsic_supported(methodHandle&, bool) shouldn't be virtual

Liu, Xin xxinliu at amazon.com
Tue Jul 28 22:01:40 UTC 2020


hi, Igor, 

Reviewed your code. you are right. I don't think it intends to be virtual. 

thanks,
--lx

________________________________________
From: hotspot-compiler-dev <hotspot-compiler-dev-retn at openjdk.java.net> on behalf of Igor Ignatyev <igor.ignatyev at oracle.com>
Sent: Tuesday, July 28, 2020 2:40 PM
To: hotspot compiler
Subject: [EXTERNAL] RFR(T) : 8250738 : C2Compiler::is_intrinsic_supported(methodHandle&, bool) shouldn't be virtual

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



http://cr.openjdk.java.net/~iignatyev//8250738/webrev.00
> 2 lines changed: 0 ins; 0 del; 2 mod;

Hi all,

could you please review this trivial one-liner which removes virtual specifier from C2Compiler::is_intrinsic_supported(methodHandle&,bool)?

from JBS:
> C2Compiler::is_intrinsic_supported(methodHandle&,bool) is declared by C2Compiler which doesn't and shouldn't have any subclasses.

webrev: http://cr.openjdk.java.net/~iignatyev//8250738/webrev.00
JBS: https://bugs.openjdk.java.net/browse/JDK-8250738

Thanks,
-- Igor



More information about the hotspot-compiler-dev mailing list