RFR[XS] 8249809 avoid calling DirectiveSet::clone(this) in compilecommand_compatibility_init

[Tobias Hartmann]

Hi Xin,

On 28.07.20 22:56, Liu, Xin wrote:
> http://cr.openjdk.java.net/~xliu/8249809/01/webrev/

Overall looks good to me.

Some style comments:
- Add a comment to 'DirectiveSetPtr' to describe its purpose
- Why not put the "cloned" logic in "operator->"?
- Do not use the _clone pointer as boolean (see "Miscellaneous" section in the style guide [1])
- Indentation in line 301-303 is wrong
- Line 306 use brackets around the "else" and move it one line up "} else {"

Best regards,
Tobias

[1] https://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/hotspot-style.html