RFR(T) : 8250797 : remove CompileReason::Reason_CTW

Igor Ignatyev igor.ignatyev at oracle.com
Wed Jul 29 23:56:17 UTC 2020


Vladimir, Katya,

Thanks for your reviews, pushed.

-- Igor

> On Jul 29, 2020, at 3:45 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Good.
> 
> Thanks
> Vladimir
> 
>> On Jul 29, 2020, at 3:24 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> 
>> oopsie, removed, http://cr.openjdk.java.net/~iignatyev//8250797/webrev.01 :
>> 
>>> diff -r e5afd04596e7 src/hotspot/share/compiler/compileTask.hpp
>>> --- a/src/hotspot/share/compiler/compileTask.hpp        Wed Jul 29 15:02:31 2020 -0700
>>> +++ b/src/hotspot/share/compiler/compileTask.hpp        Wed Jul 29 15:02:53 2020 -0700
>>> @@ -133,7 +133,6 @@
>>>  bool         should_wait_for_compilation() const {
>>>    // Wait for blocking compilation to finish.
>>>    switch (_compile_reason) {
>>> -        case Reason_CTW:
>>>        case Reason_Replay:
>>>        case Reason_Whitebox:
>>>        case Reason_Bootstrap:
>> 
>> thanks for noticing. for luck, I've started builds-tier1 job.
>> 
>> -- Igor
>> 
>>> On Jul 29, 2020, at 1:54 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>> 
>>> Igor,
>>> 
>>> You missed reference in should_wait_for_compilation().
>>> 
>>> Thanks,
>>> Vladimir K
>>> 
>>>> On 7/29/20 12:34 PM, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.net/~iignatyev//8250797/webrev.00
>>>>> 5 lines changed: 0 ins; 4 del; 1 mod;
>>>> Hi all,
>>>> could you please review this patch?
>>>> from JBS:
>>>>> "native" CTW has been removed by JDK-8213812 (JDK-8214917), so CompileReason::Reason_CTW isn't used anymore and should be removed.
>>>> besides removing CompileReason::Reason_CTW and corresponding element from reason_names[] array, the patch also updates the comment for CompileReason as CompileTask::can_become_stale doesn't really depend on the order.
>>>> webrev:
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8250797
>>>> -- Igor
>> 
> 



More information about the hotspot-compiler-dev mailing list