RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field(Internet mail)

[jiefu(傅杰)]

Hi Tobias,


Thanks for your review and comments.


Updated: http://cr.openjdk.java.net/~jiefu/8250825/webrev.02/


 - Rename the test to TestMisalignedUnsafeAccess.java

 - Add @summary tag

 - Remove Xbatch

 - Remvoe initUnsafe



It seems better now.

Thanks.


Best regards,

Jie


________________________________
From: Tobias Hartmann <tobias.hartmann at oracle.com>
Sent: Friday, July 31, 2020 3:49 PM
To: jiefu(傅杰); Vladimir Kozlov; hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field(Internet mail)

Hi Jie,

On 31.07.20 07:06, jiefu(傅杰) wrote:
>  http://cr.openjdk.java.net/~jiefu/8250825/webrev.01/

Looks good to me.

Some comments regarding TestUnsafeAccess.java:
- Maybe rename the test to something more meaningful, for example "TestMisalignedUnsafeAccess" and
add a small comment in the @summary tag
- Xcomp already implies Xbatch [1]
- I don't think you need 'initUnsafe' in the test, you can just use Unsafe.getUnsafe [2]

Best regards,
Tobias

[1] http://hg.openjdk.java.net/jdk/jdk/file/83aeb4b1079b/src/hotspot/share/runtime/arguments.cpp#l1612
[2]
http://hg.openjdk.java.net/jdk/jdk/file/83aeb4b1079b/test/hotspot/jtreg/compiler/unsafe/UnsafeGetStableArrayElement.java#l67