[15] RFR(S): 8245957: Remove unused LIR_OpBranch::type after SPARC port removal

Tobias Hartmann tobias.hartmann at oracle.com
Tue Jun 2 06:30:14 UTC 2020


Thanks Vladimir!

Best regards,
Tobias

On 02.06.20 03:56, Vladimir Kozlov wrote:
> +1 for 2)
> 
> Thanks,
> Vladimir
> 
> On 5/27/20 6:42 AM, Doerr, Martin wrote:
>> Hi Tobias,
>>
>>> I would prefer 2).
>> +1
>>
>> Thanks for cleaning this up. Looks good to me.
>>
>> Best regards,
>> Martin
>>
>>
>>> -----Original Message-----
>>> From: hotspot-compiler-dev <hotspot-compiler-dev-
>>> bounces at openjdk.java.net> On Behalf Of Tobias Hartmann
>>> Sent: Mittwoch, 27. Mai 2020 14:04
>>> To: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
>>> Subject: [15] RFR(S): 8245957: Remove unused LIR_OpBranch::type after
>>> SPARC port removal
>>>
>>> Hi,
>>>
>>> please review the following patch that removes LIR_OpBranch::type after
>>> the only remaining usage [1]
>>> was removed with the SPARC port removal (JDK-8244224).
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8245957
>>>
>>> We have two options:
>>> 1) Keep the type asserts in LIR_OpBranch::branch:
>>> http://cr.openjdk.java.net/~thartmann/8245957/webrev.v1.00/
>>> 2) Remove the asserts:
>>> http://cr.openjdk.java.net/~thartmann/8245957/webrev.v2.00/
>>>
>>> I would prefer 2).
>>>
>>> Best regards,
>>> Tobias
>>>
>>> [1]
>>> https://hg.openjdk.java.net/jdk/jdk/file/ae7ed29a5f70/src/hotspot/cpu/spa
>>> rc/c1_LIRAssembler_sparc.cpp#l597


More information about the hotspot-compiler-dev mailing list