[15] RFR(S): 8246453: TestClone crashes with "all collected exceptions must come from the same place"

[Tobias Hartmann]

Hi,

I've missed to handle the case when 'array_copy_requires_gc_barriers' is true (for example, if ZGC
is enabled). We need to set deoptimize_on_exception=true for the slow call to the arraycopy stub:
http://cr.openjdk.java.net/~thartmann/8246453/webrev.01/

Thanks,
Tobias

On 03.06.20 15:39, Tobias Hartmann wrote:
> Hi Nils,
> 
> thanks for the review!
> 
> Best regards,
> Tobias
> 
> On 03.06.20 15:37, Nils Eliasson wrote:
>> Hi Tobias,
>>
>> Looks good!
>>
>> Best regards,
>> Nils
>>
>> On 2020-06-03 15:21, Tobias Hartmann wrote:
>>> Hi,
>>>
>>> please review the following patch:
>>> https://bugs.openjdk.java.net/browse/JDK-8246453
>>> http://cr.openjdk.java.net/~thartmann/8246453/webrev.00/
>>>
>>> Similar to old JDK-8033626 [1], we assert when trying to merge two JVMStates with different
>>> reexecute settings. This only happens with -XX:+StressReflectiveCode because in that case we don't
>>> fold the array guard and emit code to allocate the array to be cloned into. The fix is to simply set
>>> deoptimize_on_exception for that allocation as well (we already set it for the non-array case [2]).
>>>
>>> Thanks,
>>> Tobias
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8033626
>>> http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/00c8a1255912
>>> [2] http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/00c8a1255912#l3.7
>>