[15] RFR(S) 8227647: [Graal] Test8009761.java fails due to "RuntimeException: static java.lang.Object compiler.uncommontrap.Test8009761.m3(boolean,boolean) not compiled"

[Igor Ignatyev]

Hi Vladimir,

looks good to me,

Thanks,
-- Igor

> On Jun 4, 2020, at 9:45 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Thank you, Tobias
> 
> On 6/4/20 9:09 AM, Tobias Hartmann wrote:
>> Hi Vladimir,
>> looks good to me but I would call the method "should_wait_for_compilation" (no new webrev required).
> 
> Changed.
> 
> Thanks,
> Vladimir
> 
>> Best regards,
>> Tobias
>> On 04.06.20 04:54, Vladimir Kozlov wrote:
>>> http://cr.openjdk.java.net/~kvn/8227647/webrev.00/
>>> https://bugs.openjdk.java.net/browse/JDK-8227647
>>> 
>>> Test failed because JVMCI after 10 sec unblock [1] blocking (-Xbatch) compilation even so Graal
>>> continue compile the method. As result WB think compilation failed.
>>> LogCompilation shows that first Graal's compilation (which is not the tested method) can take > 10
>>> sec on slow machine because Graal is run in Interpreter mode and is gradually compiled by C1 (which
>>> is also consumes CPU resources).
>>> 
>>> I suggest to wait compilation finished if request came from testing environment (WB, CTW, replay,...)
>>> 
>>> Tested hs-tier1,hs-tier3-graal and many runs of failed test.
>>> Thanks,
>>> Vladimir
>>> 
>>> [1]
>>> http://hg.openjdk.java.net/jdk/jdk/file/0a32396f7a69/src/hotspot/share/compiler/compileBroker.cpp#l1583