RFR(S): 8242923: Trigger interface MethodHandle resolve in test without Nashorn.

[Igor Ignatyev]

Hi Evgeny,

LGTM

-- Igor

> On Jun 10, 2020, at 4:25 AM, Evgeny Nikitin <evgeny.nikitin at oracle.com> wrote:
> 
> Hi Igor,
> 
> Please find fixed version at http://cr.openjdk.java.net/~enikitin/8242923/webrev.02/
> 
> >   - can you use Path.resolve("/tmp/some_file") instead of new File..:toPath?
> 
> Well, Path.of(...), I guess. Path.resolve is not static. Fixed.
yes, I meant Path::of; don't know why I wrote Path.resolve... 
> 
> Thanks in advance,
> //Evgeny.
> 
> 
> On 2020-06-03 05:54, Igor Ignatyev wrote:
>> Hi Evgeny,
>> looks good to me, a couple editorial nits in CreatesInterfaceDotEqualsCallInfo.java:
>>  - at L#39, you have double space b/w throws and Throwable;
>>  - I don't feel like line breaks at L#41, L#42 and L#44 make it more readable;
>>  - can you use Path.resolve("/tmp/some_file") instead of new File..:toPath?
>>  - "/tmp/some_file" might confuse future readers into believe that's important that file is in /tmp or doesn't exist or smth else; so I'd prefer to just use "."
>> Thanks,
>> -- Igor
>>> On May 28, 2020, at 12:22 PM, Evgeny Nikitin <evgeny.nikitin at oracle.com> wrote:
>>> 
>>> Hi,
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8242923
>>> Webrev: http://cr.openjdk.java.net/~enikitin/8242923/webrev.01/
>>> 
>>> The test used Nashorn to trigger incorrect MethodHandle resolve in the linkResolver.cpp (which in turn caused crash on the MethodHandle invokation).
>>> 
>>> Test's functionality have been checked via rolling back the fix made in the https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2013-October/012155.html, the test fails on 4 common platforms in mach5.
>>> 
>>> The version with the bugfix reverted can be found here: http://cr.openjdk.java.net/~enikitin/8242923/webrev.00/
>>> 
>>> The change has been checked in mach5 for the 4 common platforms (passed).
>>> 
>>> Please review,
>>> /Evgeny Nikitin.