RFR(S): 8243670: Unexpected test result caused by C2 MergeMemNode::Ideal

[Tobias Hartmann]

Hi Felix,

On 15.06.20 10:49, Yangfei (Felix) wrote:
> Sorry for the late reply. 
> Not sure if I understand correctly.  Do you mean something like this?
> 
> diff -r 6ab7805df10d src/hotspot/share/opto/memnode.cpp
> --- a/src/hotspot/share/opto/memnode.cpp        Sat Jun 13 01:00:00 2020 +0200
> +++ b/src/hotspot/share/opto/memnode.cpp        Mon Jun 15 16:40:57 2020 +0800
> @@ -4618,7 +4618,8 @@
>          }
>          if (phi_mem != NULL) {
>            // equivalent phi nodes; revert to the def
> -          new_mem = new_base;
> +          if (phi_base->adr_type()->higher_equal(phi_mem->adr_type()))
> +            new_mem = new_base;
>          }
>        }
>      }

Yes, that would fix the issue you are seeing, right?

Best regards,
Tobias