RFR(S): Remove some dead code in C2

Tobias Hartmann tobias.hartmann at oracle.com
Wed Jun 17 10:19:13 UTC 2020


Hi Ludovic,

testing this, I'm hitting the "unexpected CallGenerator" assert with all kinds of tests. I see that
you've sent a patch for that as well but here it happens without -XX:+AlwaysIncrementalInline. The
reason for that is that before your patch !delayed_forbidden was always true and therefore the
assert condition did always hold.

I would suggest to fix both issues in one.

I've also noticed that the extra brackets around "((should_delay || AlwaysIncrementalInline))"
should be removed.

Instead of sending patches inlined into emails, you could temporarily upload a webrev to webspace
other that cr.openjdk.java.net to make it easier to review.

Best regards,
Tobias

On 17.06.20 10:16, Tobias Hartmann wrote:
> Hi Ludovic,
> 
> On 17.06.20 07:17, Ludovic Henry wrote:
>> I do not have authorship, so feel free to take my change and commit them directly (if that's the appropriate thing to do of course!). I'll work with a colleague who has authorship to get a webrev going, but feel free to take it from there if you want to see it happen sooner rather than later.
> 
> Looks good to me too. I'll sponsor.
> 
> Best regards,
> Tobias
> 


More information about the hotspot-compiler-dev mailing list